onnx2keras#3
Open
bang6319 wants to merge 6 commits into
Open
Conversation
sarahaguasvivas
requested changes
Mar 15, 2022
sarahaguasvivas
left a comment
sarahaguasvivas
left a comment
Collaborator
There was a problem hiding this comment.
Very good work, Bao,
Now, let's see if it integrates well with the rest of the software
| from onnx2keras import onnx_to_keras | ||
|
|
||
| def onnx2keras(file): | ||
| # Load ONNX model |
Collaborator
There was a problem hiding this comment.
Please add more comments on what the function does using this template:
/*------------------------------------------------- FUNCTION_NAME -----
| Function FUNCTION_NAME
|
| Purpose: EXPLAIN WHAT THIS FUNCTION DOES TO SUPPORT THE CORRECT
| OPERATION OF THE PROGRAM, AND HOW IT DOES IT.
|
| Parameters:
| parameter_name (IN, OUT, or IN/OUT) -- EXPLANATION OF THE
| PURPOSE OF THIS PARAMETER TO THE FUNCTION.
| (REPEAT THIS FOR ALL FORMAL PARAMETERS OF
| THIS FUNCTION.
| IN = USED TO PASS DATA INTO THIS FUNCTION,
| OUT = USED TO PASS DATA OUT OF THIS FUNCTION
| IN/OUT = USED FOR BOTH PURPOSES.)
|
| Returns: IF THIS FUNCTION SENDS BACK A VALUE VIA THE RETURN
| MECHANISM, DESCRIBE THE PURPOSE OF THAT VALUE HERE.
*-------------------------------------------------------------------*/
| @@ -0,0 +1,27 @@ | |||
| from nn4mc.parser._parser import Parser | |||
Collaborator
There was a problem hiding this comment.
TODO(sarahaguasvivas): Use test_translator to see if nn4mc doesn't crash with these models:
https://github.com/correlllab/nn4mc_py/blob/master/tests/test_translator/test_full.py
Create a new one called test_full_onnx.py
Hi, Here is the def parseWeights that I made for _onnxparser.py based on one from HDF5. Bao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Sarah,
Here's my onnx2keras feature branch